From d393ae787d40fe26173b9f429dcdac8b253e183e Mon Sep 17 00:00:00 2001
From: Leon Hoppe <leon@ladenbau-hoppe.de>
Date: Sun, 18 Jan 2026 17:42:37 +0100
Subject: [PATCH] Code cleanup + new pipeline setup

---
 .gitlab-ci.yml                                |  6 +-
 .idea/.idea.HopFrame/.idea/workspace.xml      | 78 ++++++++++++-------
 .../Components/Dialogs/HopFrameEditor.razor   |  6 +-
 .../Components/Pages/HopFrameTablePage.razor  | 41 ++++------
 4 files changed, 72 insertions(+), 59 deletions(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index aa87319..e4d8dd1 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -60,10 +60,8 @@ publish:
 
 publish-help:
   stage: publish-help
-  image: docker:latest
-  services:
-    - name: docker:dind
-      alias: docker
+  tags:
+    - docker
   script:
     - export VERSION=$(echo $CI_COMMIT_TAG | sed 's/^v//')
     - cd docs
diff --git a/.idea/.idea.HopFrame/.idea/workspace.xml b/.idea/.idea.HopFrame/.idea/workspace.xml
index 85f3cbc..59bf169 100644
--- a/.idea/.idea.HopFrame/.idea/workspace.xml
+++ b/.idea/.idea.HopFrame/.idea/workspace.xml
@@ -11,7 +11,12 @@
     <option name="autoReloadType" value="SELECTIVE" />
   </component>
   <component name="ChangeListManager">
-    <list default="true" id="0648788e-7696-4e60-bf12-5d5601f33d8c" name="Changes" comment="" />
+    <list default="true" id="0648788e-7696-4e60-bf12-5d5601f33d8c" name="Changes" comment="">
+      <change beforePath="$PROJECT_DIR$/.gitlab-ci.yml" beforeDir="false" afterPath="$PROJECT_DIR$/.gitlab-ci.yml" afterDir="false" />
+      <change beforePath="$PROJECT_DIR$/.idea/.idea.HopFrame/.idea/workspace.xml" beforeDir="false" afterPath="$PROJECT_DIR$/.idea/.idea.HopFrame/.idea/workspace.xml" afterDir="false" />
+      <change beforePath="$PROJECT_DIR$/src/HopFrame.Web/Components/Dialogs/HopFrameEditor.razor" beforeDir="false" afterPath="$PROJECT_DIR$/src/HopFrame.Web/Components/Dialogs/HopFrameEditor.razor" afterDir="false" />
+      <change beforePath="$PROJECT_DIR$/src/HopFrame.Web/Components/Pages/HopFrameTablePage.razor" beforeDir="false" afterPath="$PROJECT_DIR$/src/HopFrame.Web/Components/Pages/HopFrameTablePage.razor" afterDir="false" />
+    </list>
     <option name="SHOW_DIALOG" value="false" />
     <option name="HIGHLIGHT_CONFLICTS" value="true" />
     <option name="HIGHLIGHT_NON_ACTIVE_CHANGELIST" value="false" />
@@ -34,6 +39,7 @@
       </map>
     </option>
     <option name="RECENT_GIT_ROOT_PATH" value="$PROJECT_DIR$" />
+    <option name="RESET_MODE" value="HARD" />
   </component>
   <component name="GitLabMergeRequestFiltersHistory">{
   &quot;lastFilter&quot;: {
@@ -48,7 +54,7 @@
   <component name="GitLabMergeRequestsSettings">{
   &quot;selectedUrlAndAccountId&quot;: {
     &quot;first&quot;: &quot;https://git.leon-hoppe.de/leon.hoppe/hopframe.git&quot;,
-    &quot;second&quot;: &quot;2d65fdcb-5f13-45ad-a7ba-91dd4a88d6e4&quot;
+    &quot;second&quot;: &quot;f58c9371-9f54-454e-a0db-5b4bc1187bad&quot;
   }
 }</component>
   <component name="HighlightingSettingsPerFile">
@@ -117,40 +123,42 @@
     <option name="hideEmptyMiddlePackages" value="true" />
     <option name="showLibraryContents" value="true" />
   </component>
-  <component name="PropertiesComponent"><![CDATA[{
-  "keyToString": {
-    ".NET Launch Settings Profile.HopFrame.Testing.Api: https.executor": "Run",
-    ".NET Launch Settings Profile.HopFrame.Testing.executor": "Run",
-    ".NET Launch Settings Profile.HopFrame.Testing: https.executor": "Run",
-    ".NET Project.HopFrame.Testing.executor": "Run",
-    "72b118b0-a6fc-4561-acdf-74f0b454dbb8.executor": "Debug",
-    "RunOnceActivity.ShowReadmeOnStart": "true",
-    "RunOnceActivity.git.unshallow": "true",
-    "b5f11219-dfc4-47a1-b02c-90ab603034fb.executor": "Debug",
-    "dcdf1689-dc07-47e4-8824-2e60a4fbf301.executor": "Debug",
-    "git-widget-placeholder": "feature/test-reports",
-    "list.type.of.created.stylesheet": "CSS",
-    "node.js.detected.package.eslint": "true",
-    "node.js.detected.package.tslint": "true",
-    "node.js.selected.package.eslint": "(autodetect)",
-    "node.js.selected.package.tslint": "(autodetect)",
-    "nodejs_package_manager_path": "npm",
-    "settings.editor.selected.configurable": "preferences.pluginManager",
-    "vue.rearranger.settings.migration": "true"
+  <component name="PropertiesComponent">{
+  &quot;keyToString&quot;: {
+    &quot;.NET Launch Settings Profile.HopFrame.Testing.Api: https.executor&quot;: &quot;Run&quot;,
+    &quot;.NET Launch Settings Profile.HopFrame.Testing.executor&quot;: &quot;Run&quot;,
+    &quot;.NET Launch Settings Profile.HopFrame.Testing: https.executor&quot;: &quot;Run&quot;,
+    &quot;.NET Project.HopFrame.Testing.executor&quot;: &quot;Run&quot;,
+    &quot;72b118b0-a6fc-4561-acdf-74f0b454dbb8.executor&quot;: &quot;Debug&quot;,
+    &quot;RunOnceActivity.ShowReadmeOnStart&quot;: &quot;true&quot;,
+    &quot;RunOnceActivity.git.unshallow&quot;: &quot;true&quot;,
+    &quot;RunOnceActivity.typescript.service.memoryLimit.init&quot;: &quot;true&quot;,
+    &quot;b5f11219-dfc4-47a1-b02c-90ab603034fb.executor&quot;: &quot;Debug&quot;,
+    &quot;dcdf1689-dc07-47e4-8824-2e60a4fbf301.executor&quot;: &quot;Debug&quot;,
+    &quot;git-widget-placeholder&quot;: &quot;dev&quot;,
+    &quot;list.type.of.created.stylesheet&quot;: &quot;CSS&quot;,
+    &quot;node.js.detected.package.eslint&quot;: &quot;true&quot;,
+    &quot;node.js.detected.package.tslint&quot;: &quot;true&quot;,
+    &quot;node.js.selected.package.eslint&quot;: &quot;(autodetect)&quot;,
+    &quot;node.js.selected.package.tslint&quot;: &quot;(autodetect)&quot;,
+    &quot;nodejs_package_manager_path&quot;: &quot;npm&quot;,
+    &quot;settings.editor.selected.configurable&quot;: &quot;preferences.pluginManager&quot;,
+    &quot;vue.rearranger.settings.migration&quot;: &quot;true&quot;
   }
-}]]></component>
+}</component>
   <component name="RunManager" selected=".NET Launch Settings Profile.HopFrame.Testing: https">
     <configuration name="HopFrame.Testing: http" type="LaunchSettings" factoryName=".NET Launch Settings Profile">
       <option name="LAUNCH_PROFILE_PROJECT_FILE_PATH" value="$PROJECT_DIR$/testing/HopFrame.Testing/HopFrame.Testing.csproj" />
       <option name="LAUNCH_PROFILE_TFM" value="net9.0" />
       <option name="LAUNCH_PROFILE_NAME" value="http" />
-      <option name="USE_EXTERNAL_CONSOLE" value="0" />
       <option name="USE_MONO" value="0" />
       <option name="RUNTIME_ARGUMENTS" value="" />
       <option name="GENERATE_APPLICATIONHOST_CONFIG" value="1" />
       <option name="SHOW_IIS_EXPRESS_OUTPUT" value="0" />
       <option name="SEND_DEBUG_REQUEST" value="1" />
       <option name="ADDITIONAL_IIS_EXPRESS_ARGUMENTS" value="" />
+      <option name="AUTO_ATTACH_CHILDREN" value="0" />
+      <option name="MIXED_MODE_DEBUG" value="0" />
       <method v="2">
         <option name="Build" />
       </method>
@@ -159,13 +167,14 @@
       <option name="LAUNCH_PROFILE_PROJECT_FILE_PATH" value="$PROJECT_DIR$/testing/HopFrame.Testing/HopFrame.Testing.csproj" />
       <option name="LAUNCH_PROFILE_TFM" value="net9.0" />
       <option name="LAUNCH_PROFILE_NAME" value="https" />
-      <option name="USE_EXTERNAL_CONSOLE" value="0" />
       <option name="USE_MONO" value="0" />
       <option name="RUNTIME_ARGUMENTS" value="" />
       <option name="GENERATE_APPLICATIONHOST_CONFIG" value="1" />
       <option name="SHOW_IIS_EXPRESS_OUTPUT" value="0" />
       <option name="SEND_DEBUG_REQUEST" value="1" />
       <option name="ADDITIONAL_IIS_EXPRESS_ARGUMENTS" value="" />
+      <option name="AUTO_ATTACH_CHILDREN" value="0" />
+      <option name="MIXED_MODE_DEBUG" value="0" />
       <method v="2">
         <option name="Build" />
       </method>
@@ -174,13 +183,14 @@
       <option name="LAUNCH_PROFILE_PROJECT_FILE_PATH" value="$PROJECT_DIR$/testing/HopFrame.Testing.Api/HopFrame.Testing.Api.csproj" />
       <option name="LAUNCH_PROFILE_TFM" value="net9.0" />
       <option name="LAUNCH_PROFILE_NAME" value="http" />
-      <option name="USE_EXTERNAL_CONSOLE" value="0" />
       <option name="USE_MONO" value="0" />
       <option name="RUNTIME_ARGUMENTS" value="" />
       <option name="GENERATE_APPLICATIONHOST_CONFIG" value="1" />
       <option name="SHOW_IIS_EXPRESS_OUTPUT" value="0" />
       <option name="SEND_DEBUG_REQUEST" value="1" />
       <option name="ADDITIONAL_IIS_EXPRESS_ARGUMENTS" value="" />
+      <option name="AUTO_ATTACH_CHILDREN" value="0" />
+      <option name="MIXED_MODE_DEBUG" value="0" />
       <method v="2">
         <option name="Build" />
       </method>
@@ -189,13 +199,14 @@
       <option name="LAUNCH_PROFILE_PROJECT_FILE_PATH" value="$PROJECT_DIR$/testing/HopFrame.Testing.Api/HopFrame.Testing.Api.csproj" />
       <option name="LAUNCH_PROFILE_TFM" value="net9.0" />
       <option name="LAUNCH_PROFILE_NAME" value="https" />
-      <option name="USE_EXTERNAL_CONSOLE" value="0" />
       <option name="USE_MONO" value="0" />
       <option name="RUNTIME_ARGUMENTS" value="" />
       <option name="GENERATE_APPLICATIONHOST_CONFIG" value="1" />
       <option name="SHOW_IIS_EXPRESS_OUTPUT" value="0" />
       <option name="SEND_DEBUG_REQUEST" value="1" />
       <option name="ADDITIONAL_IIS_EXPRESS_ARGUMENTS" value="" />
+      <option name="AUTO_ATTACH_CHILDREN" value="0" />
+      <option name="MIXED_MODE_DEBUG" value="0" />
       <method v="2">
         <option name="Build" />
       </method>
@@ -267,6 +278,8 @@
       <workItem from="1744966207145" duration="5231000" />
       <workItem from="1751713720880" duration="8243000" />
       <workItem from="1751741813788" duration="4623000" />
+      <workItem from="1768753475773" duration="455000" />
+      <workItem from="1768753946559" duration="344000" />
     </task>
     <task id="LOCAL-00016" summary="Added documentation for the configurators and service extensions methods">
       <option name="closed" value="true" />
@@ -688,6 +701,17 @@
   </component>
   <component name="UnityCheckinConfiguration" checkUnsavedScenes="true" />
   <component name="UnityProjectConfiguration" hasMinimizedUI="false" />
+  <component name="Vcs.Log.Tabs.Properties">
+    <option name="TAB_STATES">
+      <map>
+        <entry key="MAIN">
+          <value>
+            <State />
+          </value>
+        </entry>
+      </map>
+    </option>
+  </component>
   <component name="VcsManagerConfiguration">
     <option name="CLEAR_INITIAL_COMMIT_MESSAGE" value="true" />
     <MESSAGE value="Added default button removal feature" />
diff --git a/src/HopFrame.Web/Components/Dialogs/HopFrameEditor.razor b/src/HopFrame.Web/Components/Dialogs/HopFrameEditor.razor
index 0302d9c..43054b8 100644
--- a/src/HopFrame.Web/Components/Dialogs/HopFrameEditor.razor
+++ b/src/HopFrame.Web/Components/Dialogs/HopFrameEditor.razor
@@ -39,11 +39,11 @@
                     </div>
                     <div style="display: flex; gap: 5px; margin-bottom: 4px">
                         @if (!property.IsRequired) {
-                            <FluentButton OnClick="async () => await SetPropertyValue(property, null, InputType.Relation)" Disabled="@(_currentlyEditing && !property.Editable)">
+                            <FluentButton OnClick="@(async () => await SetPropertyValue(property, null, InputType.Relation))" Disabled="@(_currentlyEditing && !property.Editable)">
                                 <FluentIcon Value="@(new Icons.Regular.Size20.Dismiss())" Color="Color.Neutral" />
                             </FluentButton>
                         }
-                        <FluentButton OnClick="async () => await OpenRelationalPicker(property)" Disabled="@(_currentlyEditing && !property.Editable)">
+                        <FluentButton OnClick="@(async () => await OpenRelationalPicker(property))" Disabled="@(_currentlyEditing && !property.Editable)">
                             <FluentIcon Value="@(new Icons.Regular.Size20.Open())" Color="Color.Neutral" />
                         </FluentButton>
                     </div>
@@ -131,7 +131,7 @@
                             ValueChanged="@(async v => await SetPropertyValue(property, v, InputType.Enum))" />
                     </div>
                     <div style="display: flex; gap: 5px">
-                        <FluentButton OnClick="async () => await SetPropertyValue(property, null, InputType.Enum)" Disabled="@(_currentlyEditing && !property.Editable)">
+                        <FluentButton OnClick="@(async () => await SetPropertyValue(property, null, InputType.Enum))" Disabled="@(_currentlyEditing && !property.Editable)">
                             <FluentIcon Value="@(new Icons.Regular.Size20.Dismiss())" Color="Color.Neutral" />
                         </FluentButton>
                     </div>
diff --git a/src/HopFrame.Web/Components/Pages/HopFrameTablePage.razor b/src/HopFrame.Web/Components/Pages/HopFrameTablePage.razor
index f649f7e..4f48825 100644
--- a/src/HopFrame.Web/Components/Pages/HopFrameTablePage.razor
+++ b/src/HopFrame.Web/Components/Pages/HopFrameTablePage.razor
@@ -24,7 +24,7 @@
         @if (!DisplaySelection && _buttonToggles.ShowRefreshButton) {
             <FluentButton
                 IconStart="@(new Icons.Regular.Size16.ArrowClockwise())"
-                OnClick="Reload"
+                OnClick="@(Reload)"
                 Loading="_loading"
                 Style="margin-left: 10px">
                 Refresh
@@ -34,7 +34,7 @@
         @foreach (var button in _pluginButtons.Where(pb => pb.IsForTable(_config)).Where(pb => pb.Position == PluginButtonPosition.TopLeft)) {
             <FluentButton
                 IconStart="@(button.Icon?.GetInstance())"
-                OnClick="() => button.Handler.Invoke(null!, _config!)">
+                OnClick="@(() => button.Handler.Invoke(null!, _config!))">
                 @button.Title
             </FluentButton>
         }
@@ -44,32 +44,33 @@
             style="position: relative; height: 32px"
             class="hopframe-search">
             
+            @* ReSharper disable once CSharpWarnings::CS4014 *@
             <FluentSearch
                 @ref="_searchBox"
                 @oninput="OnSearch"
                 @onchange="OnSearch"
                 @onfocusin="() => { SearchFocus(); UpdateSearchSuggestions(); }"
-                @onfocusout="SearchUnfocus"
+                @onfocusout="@(SearchUnfocus)"
                 Style="width: 500px"/>
 
             @if (_isSearchActive && _searchSuggestions.Count > 0) {
                 <FluentListbox
                     TOption="string"
                     Items="_searchSuggestions"
-                    SelectedOptionChanged="SearchSuggestionSelected"
-                    @onfocusin="SearchFocus"
-                    @onfocusout="SearchUnfocus"/>
+                    SelectedOptionChanged="@(SearchSuggestionSelected)"
+                    @onfocusin="@(SearchFocus)"
+                    @onfocusout="@(SearchUnfocus)"/>
             }
         </div>
         
         @if (_hasCreatePolicy && DisplayActions && _buttonToggles.ShowAddEntityButton) {
-            <FluentButton OnClick="async () => { await CreateOrEdit(null); }">Add Entity</FluentButton>
+            <FluentButton OnClick="@(async () => { await CreateOrEdit(null); })">Add Entity</FluentButton>
         }
 
         @foreach (var button in _pluginButtons.Where(pb => pb.IsForTable(_config)).Where(pb => pb.Position == PluginButtonPosition.TopRight)) {
             <FluentButton
                 IconStart="@(button.Icon?.GetInstance())"
-                OnClick="() => button.Handler.Invoke(null!, _config!)">
+                OnClick="@(() => button.Handler.Invoke(null!, _config!))">
                 @button.Title
             </FluentButton>
         }
@@ -84,7 +85,7 @@
                         TGridItem="object"
                         SelectMode="SelectionMode"
                         SelectFromEntireRow="true"
-                        OnSelect="data => SelectItem(data.Item, data.Selected)"
+                        OnSelect="@(data => SelectItem(data.Item, data.Selected))"
                         SelectAllDisabled="true"
                         Property="o => DialogData!.SelectedObjects.Contains(o)"
                         Style="min-width: max-content; height: 44px; display: grid; align-items: center" />
@@ -100,19 +101,19 @@
                 @if (DisplayActions && (_hasDeletePolicy || _hasUpdatePolicy)) {
                     <TemplateColumn Title="Actions" Align="@Align.End" Style="min-height: 44px; min-width: max-content">
                         @foreach (var button in _pluginButtons.Where(pb => pb.IsForTable(_config)).Where(pb => pb.Position == PluginButtonPosition.OnEntry)) {
-                            <FluentButton OnClick="() => button.Handler.Invoke(context, _config!)">
+                            <FluentButton OnClick="@(() => button.Handler.Invoke(context, _config!))">
                                 <FluentIcon Value="@(button.Icon!.GetInstance())" />
                             </FluentButton>
                         }
                         
                         @if (_hasUpdatePolicy && _buttonToggles.ShowEditButton) {
-                            <FluentButton aria-label="Edit entry" OnClick="async () => { await CreateOrEdit(context); }">
+                            <FluentButton aria-label="Edit entry" OnClick="@(async () => { await CreateOrEdit(context); })">
                                 <FluentIcon Value="@(new Icons.Regular.Size16.Edit())"/>
                             </FluentButton>
                         }
 
                         @if (_hasDeletePolicy && _buttonToggles.ShowDeleteButton) {
-                            <FluentButton aria-label="Delete entry" OnClick="async () => { await DeleteEntry(context); }">
+                            <FluentButton aria-label="Delete entry" OnClick="@(async () => { await DeleteEntry(context); })">
                                 <FluentIcon Value="@(new Icons.Regular.Size16.Delete())" Color="Color.Warning"/>
                             </FluentButton>
                         }
@@ -124,7 +125,7 @@
 
     @if (_totalPages > 1) {
         <div class="hopframe-paginator">
-            <FluentButton BackgroundColor="transparent" OnClick="async () => await ChangePage(_currentPage - 1)">
+            <FluentButton BackgroundColor="transparent" OnClick="@(async () => await ChangePage(_currentPage - 1))">
                 <FluentIcon Value="@(new Icons.Regular.Size20.ArrowPrevious())" Color="Color.Neutral" />
             </FluentButton>
 
@@ -139,7 +140,7 @@
 
             <span>of @_totalPages</span>
 
-            <FluentButton BackgroundColor="transparent" OnClick="async () => await ChangePage(_currentPage + 1)">
+            <FluentButton BackgroundColor="transparent" OnClick="@(async () => await ChangePage(_currentPage + 1))">
                 <FluentIcon Value="@(new Icons.Regular.Size20.ArrowNext())" Color="Color.Neutral" />
             </FluentButton>
         </div>
@@ -173,7 +174,7 @@
 
 <FluentToastProvider MaxToastCount="10" />
 
-<InputFile style="display: none" @ref="FileInputElement" OnChange="OnInputFiles"></InputFile>
+<InputFile style="display: none" @ref="FileInputElement" OnChange="@(OnInputFiles)"></InputFile>
 
 @inject IContextExplorer Explorer
 @inject NavigationManager Navigator
@@ -220,8 +221,6 @@
     private bool _hasDeletePolicy;
     private bool _hasCreatePolicy;
 
-    private bool _allSelected;
-
     private readonly CancellationTokenSource _tokenSource = new();
     private List<PluginButton> _pluginButtons = new();
     private DefaultButtonToggles _buttonToggles = new();
@@ -443,14 +442,6 @@
         else DialogData!.SelectedObjects.Add(item);
     }
 
-    private void SelectAll() {
-        var selected = CurrentlyDisplayedModels.All(DialogData!.SelectedObjects.Contains);
-        foreach (var displayedModel in CurrentlyDisplayedModels) {
-            SelectItem(displayedModel, !selected);
-        }
-        _allSelected = selected;
-    }
-
     private async Task<string> DisplayProperty(PropertyConfig config, object entry) {
         var display = await _manager!.DisplayProperty(entry, config);